Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.6 #14831

Merged
merged 37 commits into from
Aug 28, 2024
Merged

8.6 #14831

merged 37 commits into from
Aug 28, 2024

Conversation

vkarpov15
Copy link
Collaborator

Summary

8.6 is ready to go

Examples

vkarpov15 and others added 30 commits July 9, 2024 10:31
types: avoid automatically inferring lean result type when assigning to explicitly typed variable
types: make `_id` required on Document type
feat(QueryCursor): add getDriverCursor() function that returns the raw driver cursor
Previously, there was a catch-all case in RootQuerySelector which would accept any key with type "any". This still allows nice IDE typehints, but can lead to bugs where the incorrect key is used for a filter with no warning that the key is clearly wrong.

With this PR, only keys that contain a "." are unsafely typed as any, which should reduce the blast radius of the hacky types dramatically.
Co-authored-by: hasezoey <hasezoey@gmail.com>
…ments(), estimatedDocumentCount(), distinct()
feat(model+query): support `options` parameter for distinct()
Refine query selector to highlight unexpected query keys
types: make toObject() and toJSON() not generic by default to avoid type widening
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also typegoose tests pass; aside from the merge conflicts)

@vkarpov15 vkarpov15 merged commit 473a636 into master Aug 28, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants