Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: make __v a number, only set __v on top-level documents #14892

Merged
merged 3 commits into from
Sep 17, 2024
Merged

types: make __v a number, only set __v on top-level documents #14892

merged 3 commits into from
Sep 17, 2024

Conversation

vkarpov15
Copy link
Collaborator

Re: #12959

Summary

Version key __v is only set on top-level documents at runtime, so TypeScript types should support that. We'll put this change in 8.7 in the interest of caution, because this may cause issues for people who use extends Document

Examples

@vkarpov15 vkarpov15 added this to the 8.7 milestone Sep 16, 2024
@vkarpov15 vkarpov15 changed the base branch from master to 8.7 September 16, 2024 21:10
hasezoey
hasezoey reviewed Sep 17, 2024
View reviewed changes
test/types/document.test.ts Outdated Show resolved Hide resolved
test/types/document.test.ts Outdated Show resolved Hide resolved
vkarpov15 and others added 2 commits September 17, 2024 11:29
@vkarpov15 @hasezoey
Update test/types/document.test.ts
11494c7 
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 @hasezoey
Update test/types/document.test.ts
05a2234 
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 vkarpov15 merged commit d28e5a0 into 8.7 Sep 17, 2024
5 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12959 branch September 17, 2024 16:48
@nejidevelops nejidevelops mentioned this pull request Oct 20, 2024
Open
@ShivamNimje6 ShivamNimje6 mentioned this pull request Oct 20, 2024
Open
@zntb zntb mentioned this pull request Oct 21, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Oct 22, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 23, 2024
Open
@sharma731 sharma731 mentioned this pull request Oct 23, 2024
Open
@axqqt axqqt mentioned this pull request Oct 23, 2024
Open
@zntb zntb mentioned this pull request Oct 24, 2024
Merged
@Sakshic24 Sakshic24 mentioned this pull request Oct 24, 2024
Open
@Tobsukka Tobsukka mentioned this pull request Oct 25, 2024
Open
@k2xl k2xl mentioned this pull request Oct 25, 2024
Open
@hamzabetbaieb hamzabetbaieb mentioned this pull request Oct 25, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Oct 25, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 25, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Oct 26, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Oct 26, 2024
Merged
@WontonSam WontonSam mentioned this pull request Oct 26, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Oct 27, 2024
Open
@desujoy desujoy mentioned this pull request Nov 4, 2024
Merged
@axqqt axqqt mentioned this pull request Nov 4, 2024
Open
@rodrigo3829l rodrigo3829l mentioned this pull request Nov 4, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Nov 4, 2024
Merged
@zntb zntb mentioned this pull request Nov 5, 2024
Merged
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 5, 2024
Merged
@saileshbro saileshbro mentioned this pull request Nov 5, 2024
Open
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 5, 2024
Merged
@MSK-009 MSK-009 mentioned this pull request Nov 5, 2024
Open
@LianJordaan LianJordaan mentioned this pull request Nov 5, 2024
Merged
@zntb zntb mentioned this pull request Nov 6, 2024
Merged
@pradumchintamani pradumchintamani mentioned this pull request Nov 6, 2024
Open
@aditya-arcot aditya-arcot mentioned this pull request Nov 6, 2024
Merged
@NotZarifGithub NotZarifGithub mentioned this pull request Nov 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Nov 6, 2024
Open
@lholmquist lholmquist mentioned this pull request Nov 6, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Nov 6, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 7, 2024
Open
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@AntenehTsegayeTessema AntenehTsegayeTessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
@zntb zntb mentioned this pull request Nov 9, 2024
Closed
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@axqqt axqqt mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @hasezoey