Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Block: Loading States #211

Closed
jeffersonrabb opened this issue Nov 12, 2019 · 2 comments
Closed

Query Block: Loading States #211

jeffersonrabb opened this issue Nov 12, 2019 · 2 comments
Labels
enhancement New feature or request Query Block

Comments

@jeffersonrabb
Copy link
Contributor

The Query block currently has content before post data becomes available. It should have a loading state like the Homepage Articles block. Ideally there should also be a transitional state when a change has been made to the Query parameters, as the block awaits an updated list of posts.
@jeffersonrabb jeffersonrabb added enhancement New feature or request Query Block labels Nov 12, 2019
georgeh pushed a commit that referenced this issue Nov 18, 2019
Add loading and missing post states
c9d9797 
Closes #211
@jeffersonrabb
Copy link
Contributor Author

I see "Sorry No Posts Were Found" UI for the time before initial post data becomes available. Ideally there would initially be a loading state, and the "Sorry" UI would be displayed only when post data has been received and is empty.

@jeffersonrabb
Copy link
Contributor Author

Query block has been relocated to core: WordPress/gutenberg#20106. Closing all Query Block issues in newspack-blocks for now, with a possibility of filing them in Core after the block approaches readiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Query Block
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffersonrabb