-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.1 refactoring #129
Merged
Merged
v.1 refactoring #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kariae
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is a major refactoring of how the plugin processes posts for conversion, with several bigger simplifications. The build process is fixed and new features are added. Plugin is now ready for v.1.
Big changes
ncc_wp_posts
and the complex queuing systemreset
CLI command to "queue" new posts. Thereset
command was completely removedNewspackContentConverter\Converter::register_filters()
where they're now hardcoded and simplifiedncc_filter_html_before_conversion
ncc_filter_blocks_after_conversion
ncc_after_post_content_updated
Smaller changes
Future steps we can take, after this v.1 gets merged and released
runSinglePost
Test instructions
add/fix-build-and-refactor
composer install
nvm use 16
npm ci
npm run build