Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove borders and padding in editor to match front-end styles #14

Merged
merged 6 commits into from
Dec 16, 2020
Merged

feat: remove borders and padding in editor to match front-end styles #14

merged 6 commits into from
Dec 16, 2020

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Dec 4, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Removes borders and padding from block editor elements so that styles more closely match both core WP design patterns and the front-end styles for listings.

Closes #9.

How to test the changes in this Pull Request:

  1. Check out this branch and run npm run build.
  2. Create or edit a curated listing block in Specific Listings mode and add several listings.
  3. Observe that the styles for rendered listing items more closely match the front-end. Example:

In the editor:
Screen Shot 2020-12-04 at 10 19 16 AM

On the front-end:
Screen Shot 2020-12-04 at 10 22 04 AM

  1. Test that it's still possible/easy enough to select the parent Curated List wrapper block in order to edit block attributes, both through the block navigation UI and by clicking near/alongside each listing item.
  2. Repeat steps 2-4 with a list in Query mode.

Bonus: Background color option

This branch also adds a new option for setting the background color of a list. To test:

  1. Create a new list in Specific Listings mode and add several listings.
  2. Open the Color Settings panel and observe a new color picker for Background Color.
  3. Confirm that the background color of the list changes in both the editor and front-end when you select a background color. Also confirm that a 1em padding is added to the list container if there's a background color applied.
  4. Repeat steps 1-3 with a list in Query mode.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the enhancement New feature or request label Dec 4, 2020
@dkoo dkoo self-assigned this Dec 4, 2020
@dkoo dkoo mentioned this pull request Dec 4, 2020
Closed
@dkoo
chore: remove unused border
29687b2
@dkoo
Merge branch 'master' into feat/improved-editor-styles
0956c92
@dkoo
feat: add Background Color option and styles
137ba2d 
We have an option for text color, why not background color, too? Also adds some padding to the container if there's a background color applied.
@dkoo
Copy link
Contributor Author

dkoo commented Dec 15, 2020

@thomasguillot This could use another review now that #12 has landed. Thanks!

thomasguillot
thomasguillot requested changes Dec 16, 2020
View reviewed changes
src/blocks/curated-list/editor.scss Outdated Show resolved Hide resolved
src/blocks/curated-list/editor.scss Outdated Show resolved Hide resolved
thomasguillot
thomasguillot approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@thomasguillot thomasguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @dkoo! 🚢

@dkoo dkoo merged commit 6c47a17 into master Dec 16, 2020
@dkoo dkoo deleted the feat/improved-editor-styles branch December 16, 2020 19:14
matticbot pushed a commit that referenced this pull request Dec 17, 2020
@semantic-release-bot
chore(release): 1.1.0-alpha.1 [skip ci]
7a53951 
# [1.1.0-alpha.1](v1.0.0...v1.1.0-alpha.1) (2020-12-17)

### Bug Fixes

* "listing type" should be a sort option by default ([684d657](684d657))
* avoid a PHP warning when updating a non-single meta value ([f5bcdfe](f5bcdfe))

### Features

* remove borders and padding in editor to match front-end styles ([#14](#14)) ([6c47a17](6c47a17))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 18, 2020
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
32eb21a 
# [1.1.0](v1.0.0...v1.1.0) (2020-12-18)

### Bug Fixes

* minor bug fixes ([#21](#21)) ([5f90bc7](5f90bc7))

### Features

* remove borders and padding in editor to match front-end styles ([#14](#14)) ([6c47a17](6c47a17))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 19, 2021
@semantic-release-bot
chore(release): 1.0.0-alpha.1 [skip ci]
77f6a29 
# 1.0.0-alpha.1 (2021-07-19)

### Bug Fixes

* avoid meta sync update error ([#95](#95)) ([cab16aa](cab16aa))
* do not register post-specific sidebars in widgets page ([#93](#93)) ([7716775](7716775))
* editor errors with reusable blocks ([#89](#89)) ([fdc46d3](fdc46d3))
* errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5))
* force alpha rebuild ([acc2075](acc2075))
* minor bug fixes ([#21](#21)) ([5f90bc7](5f90bc7))
* missing condition for block appender in list container ([#74](#74)) ([2c49896](2c49896))
* syncing attributes from curated list block to inner blocks ([#64](#64)) ([cdbc0bb](cdbc0bb))
* use synced attributes for ListContainer directly ([#73](#73)) ([f8641a7](f8641a7))

### Features

* add block patterns ([#23](#23)) ([a273a40](a273a40))
* bump max number of items per list from 20 to 50 ([#97](#97)) ([009deab](009deab))
* initial post type and block setup ([#1](#1)) ([47dc0c1](47dc0c1))
* listing taxonomies and query mode ([#6](#6)) ([528e1e5](528e1e5))
* more block patterns (real estate, classified ads) ([#84](#84)) ([a51f5af](a51f5af))
* new Curated List block, block pattern, and map functionality ([#3](#3)) ([9be6e7e](9be6e7e))
* remove borders and padding in editor to match front-end styles ([#14](#14)) ([6c47a17](6c47a17))

* v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81)

### BREAKING CHANGES

* This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost.

To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasguillot thomasguillot thomasguillot approved these changes

Assignees

@dkoo dkoo

Labels
enhancement New feature or request released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[design] Focused vs. unfocused styles
3 participants
@dkoo @matticbot @thomasguillot