Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on M1 macOS #1910

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Fix building on M1 macOS #1910

merged 1 commit into from
Nov 11, 2021

Conversation

LinusU
Copy link
Collaborator

@LinusU LinusU commented Oct 17, 2021


This change JPEG detection to go thru pkg-config.

I also needed to add the new homebrew directory to the gif part in order for it to pick up giflib. I did try to also add /no/folder/here to see that it doesn't error out if the folder doesn't exists, and that seems to work.

That being said, it would be great if some people can try this out on different operating systems!

fixes #1839 #1733

@tansanDOTeth
Copy link

tansanDOTeth commented Nov 1, 2021

I installed this package with the command below. I am still getting this error Symbol not found: _cairo_fill.

npm install Automattic/node-canvas#m1

@donmccurdy
Copy link

This PR fixes the issue I'd reported in #1923, thanks!

  • macOS Monterey 12.0.1
  • M1 Pro chip

Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with it then!

I'll try to make builds and a release this weekend btw (although we don't have ARM builds setup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install in Apple M1
4 participants