Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Freetype, JPEG, Giflib, and Pango on Windows #620

Closed
wants to merge 6 commits into from

Conversation

3p3r
Copy link

@3p3r 3p3r commented Sep 4, 2015

I have only tested this with Visual Studio 2013 (Update 5) x64 build. Following versions of dependencies I have used:

Note that I have not used the same Freetype that comes with GTK+, because it was slightly outdated and I would rather building Freetype from scratch since it uses CMake and it takes literally two minutes to build and install it. After installation include/freetype2 needs to be renamed to include/freetype.

Giflib comes with autoconf scripts for its build management. Honestly the easiest way to build it, is just including it in the source tree. That's how Leptonica builds it as well.

@3p3r
Copy link
Author

3p3r commented Sep 4, 2015

Almost forgot, two other things needed to be added in order to get the compilation going:

  1. A dummy unistd.h for Freetype and GifLib.
  2. An implementation for strndup on Windows.

@terrancesnyder
Copy link

Holy font batman! +1000 on this.

@iongion
Copy link

iongion commented Sep 21, 2017

+1K - I couldnt use node-canvas on windows if not for this issue, mentioning the proper prebuilt GTK bundle

@LinusU
Copy link
Collaborator

LinusU commented Sep 21, 2017

@sepehr-laal would you mind rebasing on latest master?

@chearon
Copy link
Collaborator

chearon commented Sep 21, 2017

+1K - I couldnt use node-canvas on windows if not for this issue, mentioning the proper prebuilt GTK bundle

It's mentioned on the wiki here. Is this PR still relevant? I didn't think there was anything wrong with the Windows build.

@zbjornson
Copy link
Collaborator

GIF support maybe? But if it's added, it should probably be optional like JPEG and SVG.

@3p3r
Copy link
Author

3p3r commented Sep 21, 2017

@LinusU it's been a long time since I looked at this PR. I know of a handful of companies and individuals who have production code off of this PR. If you don't mind, I am going to submit a new PR and close this as is for historical references.

@LinusU
Copy link
Collaborator

LinusU commented Sep 21, 2017

Sounds good 👍

@zbjornson
Copy link
Collaborator

Closing per:

I am going to submit a new PR and close this as is for historical references.

@zbjornson zbjornson closed this Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants