Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm dependencies (especially @wordpress) #7695

Draft
wants to merge 23 commits into
base: trunk
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/blocks/quiz/quiz-block/quiz-edit.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jest.mock( './use-update-quiz-has-questions-meta' );
jest.mock( './quiz-validation' );
jest.mock( '../quiz-store' );
jest.mock( './quiz-settings' );
jest.mock( '@wordpress/edit-post', () => ( {} ) );

jest.mock( '../../../shared/blocks/use-auto-inserter', () => ( {
useAutoInserter: jest.fn(),
Expand All @@ -33,6 +32,7 @@ jest.mock( '@wordpress/block-editor', () => ( {
useBlockProps: jest.fn().mockImplementation( () => ( {
className: 'test',
} ) ),
InnerBlocks: () => <div />,
} ) );

describe( 'addQuestionGeneratorUpsellButtonToQuizBlock', () => {
Expand Down
2 changes: 1 addition & 1 deletion assets/home/notices.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const NoticeActions = ( { actions } ) => {
return (
<div className="sensei-notice__actions">
{ actions.map( ( action ) => (
<NoticeAction key={ action.url } action={ action } />
<NoticeAction key={ action.label } action={ action } />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the key will be always available since url is not always available.

) ) }
</div>
);
Expand Down
Loading
Loading