Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter course IDs associated with a given teacher #7702

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Filter course IDs associated with a given teacher #7702

merged 5 commits into from
Nov 6, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Nov 4, 2024 •
edited
Loading

Part of https://github.com/Automattic/sensei-pro/issues/2617.

Proposed Changes

Add a filter for the course IDs associated with a given teacher.

Testing Instructions

See https://github.com/Automattic/sensei-pro/pull/2621.

New/Updated Hooks

  • sensei_teacher_course_ids - Filter the course IDs associated with a given teacher.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added the Hooks This change adds or modifies one or more hooks. label Nov 4, 2024
@donnapep donnapep added this to the 4.24.4 milestone Nov 4, 2024
@donnapep donnapep self-assigned this Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep requested a review from a team November 4, 2024 21:27
m1r0
m1r0 previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small changelog suggestion. 🙂

Feel free to merge after that one is solved.

changelog/fix-co-teachers-get-students Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep merged commit a7076db into trunk Nov 6, 2024
22 checks passed
@donnapep donnapep deleted the fix/co-teachers-get-students branch November 6, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1r0 m1r0 m1r0 left review comments

Assignees

@donnapep donnapep

Labels
Hooks This change adds or modifies one or more hooks.
Projects
None yet
Milestone
4.24.4
Development

Successfully merging this pull request may close these issues.
2 participants
@donnapep @m1r0