Merge changes from release 2.21 finalization #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This must have been due to rename iterations
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice it's all localizations, the build number, and... a bunch of new automation for the download and upload of localized metadata.
Something must have changed in App Store Connect since the last submission of Simplenote macOS, as I was not able to submit the app for review the first time I tried due to missing localized metadata, something that (as the lack of automation shows) we never run into before.
Anyway... I added just enough automation to get it done. More to come as part of the release automation modernization for Simplenote, internal ref paaHJt-6Zx-p2).
@Automattic/apps-infrastructure I'd appreciate a look, even though the fact that everything worked is already good proof of the validity of the changes. Thanks!
See also: