Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cropped focus outline style for sidebar buttons #102

Merged
merged 1 commit into from
May 8, 2024

Conversation

SiobhyB
Copy link

@SiobhyB SiobhyB commented May 8, 2024

Related to #82 (review)

Proposed Changes

  • The focus outline style for the sidebar buttons is slightly cropped on the left. The reason for this is that the changes in Ensure only bordering areas of app are draggable #82 removed the button's left margin, leaving no longer space for the extra border to be displayed.
  • With this PR, a small amount of left margin is added back to the buttons (this is then subtracted from the main sidebar).

Testing Instructions

  • Navigate through the app using your keyboard and verify that the focus outline style appears as expected, no longer cropped.
  • In addition, verify that it's still possible to drag the left border and that the amount of space it's possible to drag isn't noticeably smaller.
Before After

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@SiobhyB SiobhyB self-assigned this May 8, 2024
@SiobhyB SiobhyB added Studio App [Type] Bug Something isn't working labels May 8, 2024
@SiobhyB SiobhyB marked this pull request as ready for review May 8, 2024 09:57
@SiobhyB SiobhyB requested a review from a team May 8, 2024 09:57
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this! 🚀

@SiobhyB SiobhyB merged commit 999d718 into trunk May 8, 2024
15 checks passed
@SiobhyB SiobhyB deleted the fix/ensure-focus-style-visibility-in-sidebar branch May 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Studio App [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants