Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev builds upload to match links used in manifest #153

Merged
merged 2 commits into from
May 23, 2024

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented May 23, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/7339

Proposed Changes

I propose to:

  • add 'universal' in links generated in manifest to match file names used when uploading binaries to CDN:

    filename_core: 'darwin-universal',

  • fix the binary upload code to use short sha instead of full one to match links used in manifest:

    const currentCommit = child_process.execSync( 'git rev-parse --short HEAD' ).toString().trim();

Testing Instructions

Test if the dev builds links in manifest work after emerging this PR.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested review from jkmassel, mokagio and a team May 23, 2024 08:53
@wojtekn wojtekn self-assigned this May 23, 2024
@wojtekn wojtekn requested a review from fluiddot May 23, 2024 08:57
@wojtekn wojtekn merged commit 30a8251 into trunk May 23, 2024
13 checks passed
@wojtekn wojtekn deleted the fix/dev-builds-upload branch May 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants