Fix dev builds upload to match links used in manifest #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/dotcom-forge/issues/7339
Proposed Changes
I propose to:
add 'universal' in links generated in manifest to match file names used when uploading binaries to CDN:
studio/fastlane/Fastfile
Line 95 in 1fe21c8
fix the binary upload code to use short sha instead of full one to match links used in manifest:
studio/scripts/generate-releases-manifest.mjs
Line 47 in 1fe21c8
Testing Instructions
Test if the dev builds links in manifest work after emerging this PR.
Pre-merge Checklist