Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify sample manifest format #157

Merged
merged 1 commit into from
May 23, 2024
Merged

Clarify sample manifest format #157

merged 1 commit into from
May 23, 2024

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented May 23, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/7339

Proposed Changes

I propose to make the sample manifest format closer to the real one.

Testing Instructions

None

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn self-assigned this May 23, 2024
@wojtekn wojtekn requested a review from a team May 23, 2024 13:51
sejas
sejas approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I see we are also adding the darwing->universal 👍

@wojtekn
Copy link
Contributor Author

wojtekn commented May 23, 2024 •
edited
Loading

I see we are also adding the darwing->universal 👍

It's correct, universal binary has been built for some time.

@wojtekn wojtekn merged commit 5cbe469 into trunk May 23, 2024
11 checks passed
@wojtekn wojtekn deleted the update/clarify-sample-manifest-format branch May 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejas sejas sejas approved these changes

Assignees

@wojtekn wojtekn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wojtekn @sejas