feat: Limit permanent warning dismissal to affirmative actions #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permanently dismissing a warning while selecting the "cancel" option is confusing as generally cancelling a dialog does not persist selections.
This option is not so much a cancellation, but either a deferment of a highly-recommended action or an acceptance of actively choosing to not heed direct advice for solving an system issue. Rephrasing the option to align with this better communicates the choice and makes the permanent dismissal option more understandable.
dcalhoun
deleted the
feat/limit-permanent-warning-dismissal-to-affirmative-actions
branch
fluiddot
pushed a commit
that referenced
this pull request
Jun 27, 2024
* feat: Limit permanent warning dismissal to affirmative actions Permanently dismissing a warning while selecting the "cancel" option is confusing as generally cancelling a dialog does not persist selections. * feat: Rephrase download optimized version cancel option This option is not so much a cancellation, but either a deferment of a highly-recommended action or an acceptance of actively choosing to not heed direct advice for solving an system issue. Rephrasing the option to align with this better communicates the choice and makes the permanent dismissal option more understandable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #287 (comment).
Proposed Changes
feat: Limit permanent warning dismissal to affirmative actions
Permanently dismissing a warning while selecting the "cancel" option is
confusing as generally cancelling a dialog does not persist selections.
feat: Rephrase download optimized version cancel option
This option is not so much a cancellation, but either a deferment of a
highly-recommended action or an acceptance of actively choosing to not
heed direct advice for solving an system issue. Rephrasing the option to
align with this better communicates the choice and makes the permanent
dismissal option more understandable.
Testing Instructions
Verify permanent dismissal is disallowed when selecting the "cancel" option
1).
Pre-merge Checklist
Footnotes
There is no need to complete all of the linked testing steps, only those related for triggering the relevant warning dialog. ↩ ↩2 ↩3