Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build CI job by updating macOS images #31

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Apr 25, 2024

Proposed Changes

  • Use different macOS images to ensure that we build x86 and arm64 architectures:

Testing Instructions

  • Observe that all CI jobs succeed.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fluiddot fluiddot requested a review from a team April 25, 2024 12:15
@fluiddot fluiddot self-assigned this Apr 25, 2024
@@ -4,6 +4,7 @@ on:
push:
branches:
- trunk
- fix/ci-macos-build-installers # Added only for testing purpose
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this once the PR is approved.

@wojtekn
Copy link
Contributor

wojtekn commented Apr 25, 2024

@fluiddot as we build on Buildkite now, do we still need the same on GH actions?

@fluiddot
Copy link
Contributor Author

@fluiddot as we build on Buildkite now, do we still need the same on GH actions?

@wojtekn As far as I know, Buildkite only produces builds for Git tags, not PRs. We could remove the GitHub actions but it might be interesting to keep them to check that PRs don't break the build process with failures. WDYT?

@wojtekn
Copy link
Contributor

wojtekn commented Apr 25, 2024

@fluiddot I see, makes sense.

@fluiddot
Copy link
Contributor Author

In the future, it would be great if the build jobs were run by Buildkite.

@fluiddot fluiddot mentioned this pull request Apr 25, 2024
1 task
Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I am checking this correctly. This is what it looks on my end:

Screenshot 2024-04-25 at 4 34 36 PM

In that case, it seems that everything succeeds! 👍

@fluiddot
Copy link
Contributor Author

I hope I am checking this correctly. This is what it looks on my end:

Screenshot 2024-04-25 at 4 34 36 PM In that case, it seems that everything succeeds! 👍

Yes, we only need to test that Build Installer CI jobs pass. Thanks @katinthehatsite for reviewing the PR 🙇 !

@fluiddot fluiddot merged commit 28aa115 into trunk Apr 25, 2024
8 checks passed
@fluiddot fluiddot deleted the fix/ci-macos-build-installers branch April 25, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants