-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build CI job by updating macOS images #31
Conversation
The OS versions used ensure that each one will build a different architecture. More info: https://github.com/actions/runner-images/tree/main?tab=readme-ov-file#available-images
@@ -4,6 +4,7 @@ on: | |||
push: | |||
branches: | |||
- trunk | |||
- fix/ci-macos-build-installers # Added only for testing purpose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this once the PR is approved.
@fluiddot as we build on Buildkite now, do we still need the same on GH actions? |
@wojtekn As far as I know, Buildkite only produces builds for Git tags, not PRs. We could remove the GitHub actions but it might be interesting to keep them to check that PRs don't break the build process with failures. WDYT? |
@fluiddot I see, makes sense. |
In the future, it would be great if the build jobs were run by Buildkite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we only need to test that |
Proposed Changes
x86
andarm64
architectures:macos-13
:x86
Intelmacos-14
:arm64
Apple siliconTesting Instructions
Pre-merge Checklist