Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Studio: fix setting menu not open if no sites #340

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Studio: fix setting menu not open if no sites #340

merged 3 commits into from
Jul 10, 2024

Conversation

kozer
Copy link
Contributor

@kozer kozer commented Jul 4, 2024

Fixes #241

Proposed Changes

This PR fixes a bug, where when the user clicks the "Settings" menu item from the onboarding screen, the menu doesn't open.

Testing Instructions

  • If sites exist, delete them all ( or make a backup in a different folder )
  • In the onboarding session, click "Studio" > "Settings" from the app menu.
  • Ensure that the settings menu, appears

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@kozer kozer self-assigned this Jul 4, 2024
@kozer kozer added the [Type] Bug Something isn't working label Jul 4, 2024
@kozer kozer requested a review from a team July 4, 2024 15:41
fluiddot
fluiddot reviewed Jul 4, 2024
View reviewed changes
src/components/app.tsx Outdated Show resolved Hide resolved
@kozer kozer requested review from fluiddot and a team July 5, 2024 07:55
wojtekn
wojtekn approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks clear. It fixes the issue for me.

@kozer kozer merged commit 8d04fae into trunk Jul 10, 2024
10 checks passed
@kozer kozer deleted the fix/settings_not_open_no_site branch July 10, 2024 14:55
@kozer kozer mentioned this pull request Jul 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekn wojtekn wojtekn approved these changes

@fluiddot fluiddot Awaiting requested review from fluiddot

Assignees

@kozer kozer

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If there is no site, the Settings menu will not open.
3 participants
@kozer @wojtekn @fluiddot