Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Vietnamese #348

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Jul 10, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/8189

Proposed Changes

I propose to add support for Vietnamese.
Ảnh màn hình 2024-07-10 lúc 09 16 54

Testing Instructions

  1. Switch the OS language to Vietnamese
  2. Confirm that Studio is translated

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team July 10, 2024 07:35
@wojtekn wojtekn self-assigned this Jul 10, 2024
@htdat
Copy link
Member

htdat commented Jul 11, 2024

FYI. With the help of @nguyenquanghoang and reviews from A12s @htdat, @itsmeichigo, @dinhtungdu, 100% strings have been just translated into Vietnamese. https://translate.wordpress.com/projects/studio/vi/default/

@nguyenquanghoang
Copy link

Amazing, Thank you so much @wojtekn @htdat

@nguyenquanghoang
Copy link

@wojtekn How can I display Vietnamese on the current Studio version (v1.0.5)?

@wojtekn wojtekn changed the title Add initial support for Vietnemese Add initial support for Vietnamese Jul 11, 2024
@wojtekn wojtekn merged commit d87aa7b into trunk Jul 11, 2024
11 checks passed
@wojtekn wojtekn deleted the add/initial-support-for-vietnamese branch July 11, 2024 09:53
@wojtekn
Copy link
Contributor Author

wojtekn commented Jul 11, 2024

How can I display Vietnamese on the current Studio version (v1.0.5)?

@nguyenquanghoang the new language will be available when 1.0.6 is released. If you want to test it now, you will need to build the app locally. See https://github.com/Automattic/studio/blob/trunk/docs/code-contributions.md

@nguyenquanghoang
Copy link

Amazing, Thank you very much

@nguyenquanghoang
Copy link

@wojtekn Can I participate in the Beta and submit feedback?

@wojtekn
Copy link
Contributor Author

wojtekn commented Jul 19, 2024

@nguyenquanghoang sure, try one of those: Mac Intel (DMG), Mac Apple Silicon (DMG), Windows,

@nguyenquanghoang
Copy link

@wojtekn Thank you very much 🙏

@nguyenquanghoang
Copy link

FYI. With the help of @nguyenquanghoang and reviews from A12s @htdat, @itsmeichigo, @dinhtungdu, 100% strings have been just translated into Vietnamese. https://translate.wordpress.com/projects/studio/vi/default/

@htdat can help me become a PTE for of Studio (This easily helps me proactively update and change quickly to best perfect the written translation)

@nguyenquanghoang
Copy link

@wojtekn Is there any way to fix the space between 2 paragraphs of text for languages ​​that have more characters than English? (Specifically, the characters when translated from English to Vietnamese will be longer, making the distance very difficult to see)

Fix Show Text - Studio

@wojtekn
Copy link
Contributor Author

wojtekn commented Jul 19, 2024

@nguyenquanghoang would you mind adding a separate issue for that?

@nguyenquanghoang
Copy link

@wojtekn Thank you for your clarification, I have filed a bug #372

@htdat
Copy link
Member

htdat commented Jul 29, 2024

@htdat can help me become a PTE for of Studio (This easily helps me proactively update and change quickly to best perfect the written translation)

Sorry for the late response here but it sounds like you have already been a validator of the Studio project for Vietnamese https://translate.wordpress.com/profile/nguyenquanghoang/

@nguyenquanghoang
Copy link

@htdat Thanks for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants