Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update delete site modal to delete files by default #352

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Update delete site modal to delete files by default #352

merged 1 commit into from
Jul 12, 2024

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Jul 11, 2024 •
edited
Loading

Related to #303

Proposed Changes

I propose to change the delete site modal to automatically check the option to delete site's files.

Screenshot 2024-07-11 at 12 11 03

Testing Instructions

  1. Add a site
  2. Open Settings tab
  3. Click 'Delete site'
  4. Confirm that option is selected by default
  5. Submit and confirm that site's directory was deleted

Then test the opposite, so after unchecking option, site's files should stay.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team July 11, 2024 10:15
@wojtekn wojtekn self-assigned this Jul 11, 2024
katinthehatsite
katinthehatsite approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look clear and work as expected on my end:

Screenshot 2024-07-11 at 9 23 05 PM

@matt-west
Copy link
Contributor

Can we tweak the description copy so that it flows a bit better:

The site's database will be lost, along with all posts, pages, comments, and media.

@wojtekn wojtekn merged commit c34bd02 into trunk Jul 12, 2024
11 checks passed
@wojtekn wojtekn deleted the update/delete-modal-to-delete-files-by-default branch July 12, 2024 09:23
@wojtekn
Copy link
Contributor Author

wojtekn commented Jul 12, 2024

@matt-west sure, but let's handle that under separate PR.

@matt-west
Copy link
Contributor

@wojtekn Opened a PR with the change here: #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katinthehatsite katinthehatsite katinthehatsite approved these changes

Assignees

@wojtekn wojtekn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojtekn @matt-west @katinthehatsite