Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Improve the loading progress bar on Windows #398

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

katinthehatsite
Copy link
Contributor

Closes: https://github.com/Automattic/dotcom-forge/issues/8340

Proposed Changes

This PR improves the loading of the progress bar on Windows by setting a starting point earlier.

Testing Instructions

  • This change would need to be tested on Windows
  • Pull the changes from this branch
  • Start the app with STUDIO_IMPORT_EXPORT=true npm start
  • Click on Add site in the left sidebar
  • Observe the loading progress starting earlier

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Jul 29, 2024
@wojtekn
Copy link
Contributor

wojtekn commented Jul 30, 2024

Start the app with STUDIO_IMPORT_EXPORT=true npm start

No need to provide that flag to test it. The code change is clear, and works better. Thanks!

@katinthehatsite katinthehatsite merged commit 488601f into trunk Jul 30, 2024
10 checks passed
@katinthehatsite katinthehatsite deleted the fix/improve-progress-bar-on-windows branch July 30, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants