-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language switcher in user settings modal #476
Conversation
Amazing, Thanks for the update @sejas 🙏 |
Amazing work @sejas ! I tested it and works as expected!
|
@kozer How to test it? |
Hey @nguyenquanghoang !
Do you face any problems while trying to replicate those instructions? |
@kozer I don't know how to do with the above instructions, Don't know what npm is? Sorry because I'm new, don't have much technical knowledge |
Sure! It's ok! After that, you should be able to clone the repo, and run the npm instructions. |
@sejas the feature works great, it's awesome that it reloads the whole UI as user changes the language.
Let's display the language selector in settings for a logged-out user, too. |
Great feature, thank you :) |
I am currently using Studio on Windows, Tried following the instructions but it didn't work. Hope it can be easier for newbies like me, just turn on Studio, log in to your WordPress .com account and select the language you want to use. |
Here is the updated screencast: 4lZZsz.mp4 |
@nguyenquanghoang, Yes, once we merge this PR and create the next release it will be as easy as starting Studio with double click. |
@sejas Yes, I have enjoyed Studio since its launch. Everything is easier for newbies like me, always fast and has the essentials. Great UI 🙏 |
Heads up that I've encountered some issues related to this PR: #502 (review) Regarding the menu items, since it's created when instantiating the main window, the strings won't be translated because the locale date is fetched after the creation. I'll work on a fix to be included before the next release. UPDATE: Here's the PR. |
Proposed Changes
The only downside is that the user needs to be logged in to open the user settings.
Testing Instructions
npm start
npm start
cmd+.
on Mac or use the menu bar to open the settings modalu9Cv10.mp4
No Auth:
Auth:
Pre-merge Checklist