Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Playground rewrite rules #505

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Fix Playground rewrite rules #505

merged 4 commits into from
Sep 3, 2024

Conversation

sejas
Copy link
Member

@sejas sejas commented Sep 3, 2024 •
edited by katinthehatsite
Loading

Proposed Changes

  • Add wordPressRewriteRules from @wp-playground/wordpress

Kudos to the whole @Automattic/yolo team for finding and fixing the issue.

Testing Instructions

  • Run 'npm install && npm start'
  • Create a page and set the permalink in the settings, or import a site with that setting
  • Observe the page renders correctly instead of a "Not found" error.

about-me-w

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Sep 3, 2024
@sejas sejas requested a review from a team September 3, 2024 10:13
fluiddot
fluiddot approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! I've confirmed that using non-plain permalink structures works as expected. Great work team @Automattic/yolo !

@sejas sejas merged commit 9d747d0 into trunk Sep 3, 2024
10 checks passed
@sejas sejas deleted the fix/playground-rewriterules branch September 3, 2024 10:49
@katinthehatsite katinthehatsite mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees

@sejas sejas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sejas @fluiddot