Studio: Clear out Site Health critical issue

[katinthehatsite]

Closes https://github.com/Automattic/dotcom-forge/issues/6652

Proposed Changes

This PR ensures that the WP_AUTO_UPDATE_CORE is not set to false when the WordPress version is user-provided. As a result, the critical issue present under Tools > Site Health is not present on a newly created Studio site anymore.

Testing Instructions

• Pull the changes from this branch
• Start the app with nvm use && npm install && npm start
• Create a new site in Studio through Add site form
• Navigate to the wp-admin of that site
• Navigate to Tools > Site Health
• Wait for a couple of minutes
• Confirm that there are no critical issues detected
• You can also compare these changes to trunk to confirm that the issue is present on trunk but not with this fix

Notes:

• The reason why WP_AUTO_UPDATE_CORE is set to false is because we are passing user-provided instead of user-defined on this line:

  studio/vendor/wp-now/src/wp-now.ts

  Line 266 in dc061f3

  await initWordPress( php, 'user-provided', documentRoot, absoluteUrl );

• I am not completely sure though if it is a typo or something that is intended. After discussing this with @jeroenpf , we decided that it would be reasonable to change it

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[wojtekn]

I am not completely sure though if it is a typo or something that is intended. After discussing this with @jeroenpf , we decided that it would be reasonable to change it

The PR fixes the issue for me. I looked into the history and tracked this change to the big refactoring that happened in Playground Tools before we brought those to the Studio project

WordPress/playground-tools@814334e#diff-eeed5d391a89564a5ff176b28d0ab5a31e01b94fb75f4ccc1d67f80297586595

It seems like a typo to me.

[katinthehatsite]

Thanks @wojtekn - that is interesting, I was trying to track it down but could not locate that change. I guess it makes sense that it was a typo!