Add Sync Push Site #662
Add Sync Push Site #662
Conversation
| getIpcApi().showErrorMessageBox( { | ||
| title: sprintf( __( 'Error pushing to %s' ), connectedSite.name ), | ||
| message: __( 'Studio was unable to connect to WordPress.com. Please try again.' ), | ||
| } ); |
There was a problem hiding this comment.
I'm displaying this generic error. I could also display the error that comes from the backend.
When trying to upload a bakcup bigger than the limit, we cannot grab the actual error message, because we receive a CORS error.
| importing: { | ||
| key: 'importing', | ||
| progress: 80, | ||
| message: __( 'Pushing changes…' ), |
There was a problem hiding this comment.
Not sure what message we could use here. Any thoughts?
There was a problem hiding this comment.
This is the only message that appears in the design. I think it's good to leave it.
Other options:
- Applying changes
- Unpacking changes
There was a problem hiding this comment.
We could also split this state using the remote states, so the user will get more information initial_backup_started, archive_import_started, etc.
There was a problem hiding this comment.
'Applying changes' sounds good for now.
There was a problem hiding this comment.
there is not system notification after the finished Push, but we have one for Pull. We can add a separate issue for that, though.
I implemented it in this PR 🥳: 8e22d1b
'Applying changes' sounds good for now.
- I've created the issue: https://github.com/Automattic/dotcom-forge/issues/9847
Related issues
Proposed Changes
Testing Instructions
You can try with a site up to 2GB in size.
STUDIO_SITE_SYNC=true npm startNERCzq.mp4
Pre-merge Checklist