-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Language Switcher #72
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3985f49
Add initial LanguagePicker component
derekblank 034050d
Move LanguagePicker component to dedicated file
derekblank 85c5983
Merge remote-tracking branch 'origin' into feat/language-picker
derekblank 3097bd8
Update user-settings tests and imports
derekblank 80868c7
Merge remote-tracking branch 'origin' into feat/language-picker
derekblank ded0c47
Merge remote-tracking branch 'origin' into feat/language-picker
derekblank c623b0f
Update LanguagePicker selection
derekblank 15efc15
Merge trunk
derekblank 1201c48
Use named and unnamed supportedLocales for testing
derekblank 99a0b07
Merge remote-tracking branch 'origin' into feat/language-picker
derekblank b7a8aca
Update linting
derekblank 79547b5
Merge remote-tracking branch 'origin' into feat/language-picker
derekblank a1b9569
Add saveUserData IpcApi handler
derekblank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import { SelectControl } from '@wordpress/components'; | ||
import { useState } from 'react'; | ||
import { getIpcApi } from '../lib/get-ipc-api'; | ||
|
||
// TODO: use supportedLocales from locale.ts | ||
export const supportedLocales = { | ||
ar: 'العربية', | ||
de: 'Deutsch', | ||
en: 'English', | ||
es: 'Español', | ||
fr: 'Français', | ||
he: 'עברית', | ||
id: 'Bahasa Indonesia', | ||
it: 'Italiano', | ||
ja: '日本語', | ||
ko: '한국어', | ||
nl: 'Nederlands', | ||
pl: 'Polski', | ||
'pt-br': 'Português (Brasil)', | ||
ru: 'Русский', | ||
sv: 'Svenska', | ||
tr: 'Türkçe', | ||
'zh-cn': '简体中文', | ||
'zh-tw': '繁體中文', | ||
}; | ||
|
||
export const LanguagePicker = () => { | ||
const [ locale, setLocale ] = useState( '' ); | ||
|
||
const handleLocaleChange = ( value: string ) => { | ||
console.log( `Switching to locale: ${ value }` ); | ||
setLocale( value ); | ||
|
||
// Save locale string to saveUserLocale | ||
getIpcApi().saveUserLocale( value ); | ||
}; | ||
|
||
return ( | ||
<div className="flex gap-5 flex-col"> | ||
<h2 className="a8c-subtitle-small">Language</h2> | ||
<SelectControl | ||
value={ locale || 'en' } | ||
onChange={ handleLocaleChange } | ||
options={ Object.entries( supportedLocales ).map( ( [ locale, name ] ) => ( { | ||
value: locale, | ||
label: name as string, | ||
} ) ) } | ||
/> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -542,6 +542,14 @@ export async function saveOnboarding( | |
} ); | ||
} | ||
|
||
export async function saveUserLocale( _event: IpcMainInvokeEvent, userLocale: string ) { | ||
const userData = await loadUserData(); | ||
await saveUserData( { | ||
...userData, | ||
userLocale, | ||
} ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this approach will be a bit limiting until userData could be saved and loaded across both the main and renderer threads. |
||
} | ||
|
||
export async function getThumbnailData( _event: IpcMainInvokeEvent, id: string ) { | ||
const path = getSiteThumbnailPath( id ); | ||
return getImageData( path ); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add Vietnamese language?