Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sidebar layout breaks on specific languages #93

Merged
merged 1 commit into from
May 8, 2024

Conversation

katinthehatsite
Copy link
Contributor

Closes ##40

Proposed Changes

This PR aligns the WordPress logo and Log in so that the layout is more consistent in multiple languages.

Before After

Testing Instructions

  • Pull the changes from this branch locally
  • Select the language in your system to be French
  • Start the app with nvm use && npm install && npm start
  • Observe that the words Se connecter are aligned in the sidebar are aligned to the right and towards the bottom
  • Quit the app
  • Try switching the languages to other such as Spanish, Polish, English and confirm that the Log in either remains on one line (when the word is short, or is aligned to the right when there are two lines)

Notes

  • You can find a bit more discussions regarding this issue here. I initially considered making the sidebar more dynamic and size it based on what is inside it to keep everything on the same line but decided against it because:
  • it might look too overpowering if the words are too long for the Log in in some languages;
  • it might affect how it looks like on other operating systems.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this May 7, 2024
@katinthehatsite katinthehatsite added Studio App [Type] Enhancement Improvement upon an existing feature labels May 7, 2024
@katinthehatsite katinthehatsite requested a review from a team May 7, 2024 08:36
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better now, thanks for the fix.

@katinthehatsite katinthehatsite merged commit e6a7385 into trunk May 8, 2024
7 of 8 checks passed
@katinthehatsite katinthehatsite deleted the fix/sidebar-layout-different-languages branch May 8, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Studio App [Type] Enhancement Improvement upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants