Use sanitizeFilepath when logging Sentry breadcrumbs #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #78 and https://github.com/Automattic/dotcom-forge/issues/6701
While reviewing Sentry logs, I noted that there is an additional place where filepaths need to be redacted.
Proposed Changes
Adds to the behavior introduced in #78 that sanitizes userpaths in console.log statements. This pr adds the same
sanitizeUserpath
util to filepath values when logging Sentry breadcrumbs, too.Testing Instructions
When running locally, log out the value of
sanitizeUserpath
whenSentry.addBreadcrumb
is logged during user data loading:studio/src/storage/user-data.ts
Lines 45 to 52 in 4d584ad
The value of filepaths should appear as
[REDACTED]
. Example error session where console.log events are usingsanitizeUserpath
, andSentry.addBreadcrumb
events are not (marked "generic" in the event logs).Pre-merge Checklist