Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sentry release param to use app version #96

Merged
merged 1 commit into from
May 7, 2024
Merged

Update Sentry release param to use app version #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Sentry.init( {
dsn: 'https://97693275b2716fb95048c6d12f4318cf@o248881.ingest.sentry.io/4506612776501248',
debug: true,
enabled: process.env.NODE_ENV !== 'development',
release: COMMIT_HASH,
release: app.getVersion() ? app.getVersion() : COMMIT_HASH,
Copy link
Contributor Author

@derekblank derekblank May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app.getVersion() is an Electron method that returns the version of the loaded application found in the app package.json file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I paused to think if we should/need to update/remove the existing COMMIT_HASH references here (or elsewhere). My thought is that retaining the references still makes sense.

Many of the other references appear to log both values, so having both likely is intentional and helpful context. I'm not sure under what circumstances this particular line would use the COMMIT_HASH.

} );

// Handle creating/removing shortcuts on Windows when installing/uninstalling.
Expand Down
Loading