Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Studio Windows installer GIF #97

Merged
merged 1 commit into from
May 8, 2024

Conversation

matt-west
Copy link
Contributor

Fixes https://github.com/Automattic/dotcom-forge/issues/6990

Proposed Changes

  • Update the Windows installer gif to fix an issue where the installer background clashes with other white windows.
Before After
loading loading

Testing Instructions

  • Install Studio on Windows.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@matt-west matt-west requested a review from a team May 7, 2024 15:32
@matt-west matt-west self-assigned this May 7, 2024
@matt-west matt-west marked this pull request as ready for review May 7, 2024 15:33
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, assuming there is a much lower chance of having a user using a black background than a white one.

Thanks for fixing that @matt-west

@matt-west matt-west merged commit 12e236e into trunk May 8, 2024
11 checks passed
@matt-west matt-west deleted the fix/windows-installer-design branch May 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants