-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varia: Fix button styles to work alongside Gutenberg 7.9 #1925
Conversation
@@ -1439,6 +1439,10 @@ button[data-load-more-btn], .button { | |||
padding: 14px 16px; | |||
} | |||
|
|||
.wp-block-button.is-style-outline .wp-block-button__link:active { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an uncompiled remnant from a previous commit? These changes shouldn't actually touch this file.
So this is a bit more complex than I had thought. I’m still gonna merge and deploy this for the visual fix, but floating in the editor on Button Blocks created before 7.9 isn’t working so well. Filed an issue for it here: WordPress/gutenberg#21685 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few changes to make sure the new outline Block style works properly. Also cleans up the alignment classes so that “legacy” Button blocks float properly on the front end. The back end needs to be fixed in the Gutenberg plugin as per this issue: WordPress/gutenberg#21685
Gonna go ahead and merge this along with #1927 right after 👍 |
This PR updates the button style editor styles so that they work alongside Gutenberg 7.9. That release changed the button markup, and now the
.wp-block-button__link
class is applied on the same element as.wp-block-button
.To test, please make sure you're running Gutenberg 7.9. This PR is essentially a mirror of Automattic/themes-workspace#75.
--
Before:
After: