Quadrat: Override BCB's index.html template #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also changed the query block for the content block since the home page can also be a static page, and that wasn't working with the current template. |
danieldudzic
approved these changes
Apr 14, 2021
100% agree, I commented on this GB issue about that and added a comment on our code, I expect this to not be needed in the future |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides the html template when we are on the home or front page and loads index.php instead.
When using do_blocks on index.php we need a header and footer templates to be defines or else we won't have css (when using html templates, the missing html from header and closing tags for the footer are provided by gutenberg, this is no longer the case when the template is built with php)