Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the theme.json schema for BCB and children #3762

Merged
merged 2 commits into from
May 5, 2021
Merged

Update the theme.json schema for BCB and children #3762

merged 2 commits into from
May 5, 2021

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

This brings Blank Canvas Blocks, Seedlet Blocks and Mayland Blocks inline with the new theme.json schema.

To test check that fonts and colors load in these themes.

@scruffian scruffian requested a review from a team May 5, 2021 16:01
@scruffian scruffian self-assigned this May 5, 2021
@pbking pbking linked an issue May 5, 2021 that may be closed by this pull request
Update the shape of theme.json #3759
Closed
pbking
pbking approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@pbking pbking merged commit 073edb6 into trunk May 5, 2021
@scruffian scruffian deleted the update/theme-json-schema branch May 5, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbking pbking pbking approved these changes

Assignees

@scruffian scruffian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the shape of theme.json
2 participants
@scruffian @pbking