Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Removing child-theme.json #4807

Closed
wants to merge 1 commit into from
Closed

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Oct 8, 2021

Changes proposed in this Pull Request:

This works with WordPress/gutenberg#35459. With that PR checked out, it should no longer be necessary to build the theme.json, Gutenberg will do it for you.

The theme should behave the same as before.

@MaggieCabrera
Copy link
Contributor

not relevant for testing purposes but when this lands and we change all themes, we should add "$schema": "https://json.schemastore.org/theme-v1.json" to all of them too

@pbking
Copy link
Contributor

pbking commented Oct 18, 2021

One thing I noticed tinkering with this is that our build process has a special scenario for the custom templates (where they are merged instead of replaced). The rest of the properties seem to be following standard procedure ok, but in order to keep the custom templates definitions consistent across this change it will need to define all of the templates expected to be available.

@scruffian
Copy link
Member Author

Closing in favour of #4861

@scruffian scruffian closed this Oct 19, 2021
@scruffian scruffian deleted the try/remove-child-theme-json branch October 19, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants