Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livro: add white and cream variations #6359

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Livro: add white and cream variations #6359

merged 4 commits into from
Aug 12, 2022

Conversation

vcanales
Copy link
Contributor

@vcanales vcanales commented Aug 9, 2022

Related issue(s):

#6276

Preview

Kapture 2022-08-10 at 12 04 50

@vcanales vcanales marked this pull request as ready for review August 10, 2022 16:08
@pbking
Copy link
Contributor

pbking commented Aug 10, 2022

It seems that the palette colors primary and tertiary aren't used in the theme at all. Can we remove them with this change (both for the primary theme.json as well as the variations?)

livro/styles/cream.json Outdated Show resolved Hide resolved
@vcanales vcanales requested a review from pbking August 10, 2022 21:25
@pbking
Copy link
Contributor

pbking commented Aug 12, 2022

I made a minor label change. The 'Primary' colors were labeled "Background" in the original and variations.

I also removed the 'initial' color value for buttons. I'm not sure why that was added but it didn't work with the hover state of buttons in the the variations.

This was otherwise good to 🚢

@pbking pbking merged commit 80bbde6 into trunk Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants