Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sass build scripts to import from node_modules #6371

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Update sass build scripts to import from node_modules #6371

merged 2 commits into from
Aug 11, 2022

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Aug 11, 2022 •
edited
Loading

Changes proposed in this Pull Request:

  • Remove relative path references to @wordpress/base-styles
  • include node_modules to sass compilation load path
  • Add style-rts.css to deployment script to avoid version mismatch
  • update deployment script to not trim -wpcom from style.scss

Related issue(s):

#6365 #6200

@madhusudhand madhusudhand requested a review from a team August 11, 2022 06:54
@madhusudhand madhusudhand self-assigned this Aug 11, 2022
@madhusudhand madhusudhand mentioned this pull request Aug 11, 2022
Closed
@madhusudhand madhusudhand changed the title Update sass build scripts to import from packages under node_modules Update sass build scripts to import from packages within node_modules Aug 11, 2022
@madhusudhand madhusudhand changed the title Update sass build scripts to import from packages within node_modules Update sass build scripts to import from node_modules Aug 11, 2022
@madhusudhand madhusudhand mentioned this pull request Aug 11, 2022
Closed
mikachan
mikachan approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ace, thanks for working on this! The update to the deploy script is great too. It all tests well for me 👍

@pbking pbking merged commit 35789df into trunk Aug 11, 2022
@madhusudhand madhusudhand deleted the sass-build-issues branch August 12, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees

@madhusudhand madhusudhand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madhusudhand @mikachan @pbking