Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Club: remove comments and pagination from page template #6373

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Club: remove comments and pagination from page template #6373

merged 1 commit into from
Aug 11, 2022

Conversation

matiasbenedetto
Copy link
Member

Changes proposed in this Pull Request:

Club: remove comments and pagination from the page template.

@matiasbenedetto matiasbenedetto self-assigned this Aug 11, 2022
@matiasbenedetto matiasbenedetto added the [Theme] Disco Automatically generated label for Disco, formerly known as Club.. label Aug 11, 2022
@matiasbenedetto matiasbenedetto added this to the club milestone Aug 11, 2022
@matiasbenedetto matiasbenedetto requested a review from a team August 11, 2022 12:28
madhusudhand
madhusudhand reviewed Aug 11, 2022
View reviewed changes
Copy link
Member

@madhusudhand madhusudhand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping a spacer between post-content and footer

Frontend:
image

Designs:
image

@matiasbenedetto
Copy link
Member Author

@madhusudhand the spacing is being worked in another PR: #6375
This PR is only to remove the comments form that should not be in the page template.

pbking
pbking approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasbenedetto matiasbenedetto merged commit b836afb into trunk Aug 11, 2022
@madhusudhand madhusudhand deleted the club/remove-comments-from-page-template branch August 12, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbking pbking pbking approved these changes

@madhusudhand madhusudhand Awaiting requested review from madhusudhand

Assignees

@matiasbenedetto matiasbenedetto

Labels
[Theme] Disco Automatically generated label for Disco, formerly known as Club..
Projects
None yet
Milestone
club
Development

Successfully merging this pull request may close these issues.
3 participants
@matiasbenedetto @pbking @madhusudhand