Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Club: removing text-decoration-thickness from theme.json #6384

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

matiasbenedetto
Copy link
Member

Changes proposed in this Pull Request:

Club: removing text-decoration-thickness from theme.json because WebKit browsers are not compatible with text-decoration shorthand syntax

Related issue(s):

Fixes: #6378
Part of: #6243

…it browsers are not compatible with text-decoration shorthand syntax
@matiasbenedetto matiasbenedetto force-pushed the club/text-decoration-thickness-compat-webkit branch from 171cb42 to 39b0708 Compare August 12, 2022 11:08
…use webkit browsers are not compatible with text-decoration shorthand syntax"

This reverts commit 39b0708.
@matiasbenedetto matiasbenedetto marked this pull request as draft August 12, 2022 11:13
…it browsers are not compatible with text-decoration shorthand syntax
@matiasbenedetto matiasbenedetto marked this pull request as ready for review August 12, 2022 11:15
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 This fixes the appearance of text underlines of links in Safari in my testing:

Before After
Screen Shot 2022-08-12 at 10 10 34 AM Screen Shot 2022-08-12 at 10 15 03 AM

I did notice that the :active state is not working for links in Safari. But that is unrelated to this PR, as it happens on trunk too.

@matiasbenedetto matiasbenedetto merged commit 352ae63 into trunk Aug 12, 2022
@matiasbenedetto matiasbenedetto deleted the club/text-decoration-thickness-compat-webkit branch August 12, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Club: text decoration too thick
3 participants