Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit of Clean Slate #6665

Merged
merged 10 commits into from
Oct 25, 2022
Merged

Initial Commit of Clean Slate #6665

merged 10 commits into from
Oct 25, 2022

Conversation

onuro
Copy link
Contributor

@onuro onuro commented Oct 7, 2022

This PR introduces the Clean Slate theme, a blank/starter theme in replacement of Blank Canvas, started out with the purpose of using in Pattern Assembler project.

This theme is a stripped down version of TT3 theme, with some more custom theme.json and template parts updates.

I've kept the fonts from TT3, as the use of a fonts library for this theme TBD.

Please let me know what could be improved with this theme, as I'm still checking for things that may be needed to be updated.

Thank you!

onuro added 3 commits October 7, 2022 16:14
The first commit of the Clean Slate theme, a blank/starter theme.
Initial commit stuck at delta. will re-commit the fonts
@scruffian
Copy link
Member

I think if we want a truly clean slate we should remove a lot more - all the patterns for example can go, and quite a few of the templates as well.

Removed all patterns from the theme
@scruffian
Copy link
Member

What happens if we remove all templates except index?

@onuro
Copy link
Contributor Author

onuro commented Oct 10, 2022

What happens if we remove all templates except index?

Tbh makes sense. @mtias this is also something along the lines of what you've expressed for this right?

clean-slate/style.css Outdated Show resolved Hide resolved
@alaczek
Copy link
Contributor

alaczek commented Oct 11, 2022

I'm also wondering about the inclusion of font assets. What do you think about removing them and reverting to using system fonts?

@arthur791004
Copy link
Contributor

arthur791004 commented Oct 11, 2022

Could we have the home.html file without any content and use it to display the home page of this theme? cc @mtias

Missing new lines in templates and parts added
clean-slate/style.css Outdated Show resolved Hide resolved
onuro added 3 commits October 11, 2022 20:08
Removed "Template:" declaration line in style.css since this is not a child theme.
Removed all custom fonts bundled with the theme
Per the decision on the name, this will be the replacement of Blank Canvas
},
"link": {
"color": {
"text": "var(--wp--preset--color--primary)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be interesting to use ref properties, to reduce the duplication: WordPress/gutenberg#41696

Copy link
Contributor Author

@onuro onuro Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scruffian could you elaborate on this? Is do I simply use the following? Because when I did, the theme.json and the theme style breaks. I also don't understand the reason fully even though I've read the PR.

"link": {
				"color": {
					"text": { ref: "styles.color.primary" }
				},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using:

"color": {
	"text": { ref: "styles.color.text" }
},

The reason being that if a user changes their body text color then links will update automatically.

@scruffian
Copy link
Member

I'm not clear how "blank" we want this to be. The templates still contain a lot of opinion. Do we want to strip it back to just display page content?

@@ -0,0 +1,360 @@
{
"customTemplates": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the customTemplates config can be removed since there is no longer a blank template supplied by the theme.

Removed custom templates declarations from the theme.json file
@onuro onuro merged commit eb2bf15 into trunk Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants