Rainfall: try using index as home template #6701
Conversation
| <!-- /wp:column --> | ||
| </div> | ||
| <!-- /wp:columns --> | ||
| </div> |
There was a problem hiding this comment.
These changes are just indenting the markup, so I could more easily see the differences between this file and home-query..
| <!-- wp:query-pagination-previous /--> | ||
| <!-- wp:query-pagination-next /--> | ||
| <!-- /wp:query-pagination --> | ||
| </div> |
There was a problem hiding this comment.
These changes are just indents too.
There was a problem hiding this comment.
These changes looks good.
While testing I have found the following minor issues.
- Search text in the search bar is same as background, so it is not visible
and is it intentional to not have the border between the posts in search and archive?
- Search/archive posts are not aligned with other content (in small screens)
|
Thanks @madhusudhand!! Good spots!
Pushed a fix here: 47b7760
Pushed a fix here: 10e49f6
No this isn't intentional, this border should show. It's a bottom border on each post element (from query.html). It's showing like this on my local site:
I wonder why it's not showing for you! |
|
Thanks for addressing the issues. It looks good now.
Thanks for confirming the issue. After a rebuild of Gutenberg it started working. It might be due to cache. |
Changes proposed in this Pull Request:
This moves the contents of the home.html template to index.html, in order to try out not including a home.html template.
I've also added an archive.html template, which uses the previous index.html content.