Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQL import prompt message #1743

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

iamchughmayank
Copy link
Contributor

@iamchughmayank iamchughmayank commented Mar 26, 2024

Description

This PR makes SQL import prompt message to handle case where table names are not available.

Changelog Description

Updates prompt message during SQL import.

Pull request checklist

New release checklist

Steps to Test

  1. Pull down the PR
  2. Run the tests.
  3. The current tests should work as expected.

In case tableNames are not available, prompt message should not point to an empty array. The generic message handles it
@saroshaga
Copy link
Contributor

Could we check for the presence of the table list and use that to conditionally build the message?

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@iamchughmayank
Copy link
Contributor Author

Could we check for the presence of the table list and use that to conditionally build the message?

Something like this: f658acc ?

@iamchughmayank iamchughmayank merged commit 54432f1 into trunk Mar 27, 2024
16 checks passed
@iamchughmayank iamchughmayank deleted the update/generic-prompt-message-sql-import branch March 27, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants