Test for SET @@SESSION.sql_log_bin in sql static validations #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchymko
previously approved these changes
Feb 1, 2021
src/lib/validations/sql.js
Outdated
| outputFormatter: errorCheckFormatter, | ||
| results: [], | ||
| message: 'SET @@SESSION.sql_log_bin statement', | ||
| excerpt: '\'SET @@SESSION.sql_log_bin=0\' statement should not be present (case-insensitive)', |
There was a problem hiding this comment.
Super minor, but we probably don't need the =0 here.
|
@markowsiak @jblz forgot to merge this before, so going to merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a test for
SET @@SESSION.sql_log_binusually added bymysqldumpto SQL files. More info https://dev.mysql.com/doc/refman/8.0/en/set-sql-log-bin.htmlSteps to Test
An automated test case was added.