Revert "fix(files): better handle directories in move() (#4970)" (#5011)

This reverts commit 39d4802.

files/class-wp-filesystem-vip.php

@@ -218,10 +218,6 @@ public function copy( $source, $destination, $overwrite = false, $mode = false )
 			return false;
 		}
 
-		if ( $source_transport instanceof WP_Filesystem_Direct && $destination_transport instanceof WP_Filesystem_Direct ) {
-			return $source_transport->copy( $source, $destination, $overwrite, $mode );
-		}
-
 		$destination_exists = $destination_transport->exists( $destination );
 		if ( ! $overwrite && $destination_exists ) {
 			/* translators: 1: destination file path 2: overwrite param 3: `true` boolean value */
@@ -252,24 +248,13 @@ public function copy( $source, $destination, $overwrite = false, $mode = false )
 	 * @return bool
 	 */
 	public function move( $source, $destination, $overwrite = false ) {
-		$source_transport      = $this->get_transport_for_path( $source );
-		$destination_transport = $this->get_transport_for_path( $destination, 'write' );
-		if ( $source_transport instanceof WP_Filesystem_Direct && $destination_transport instanceof WP_Filesystem_Direct ) {
-			return $source_transport->move( $source, $destination, $overwrite );
-		}
-
-		// WP_Filesystem_Direct::get_contents() invoked by copy() will return '' for directories; this will result in directories being copied as empty files.
-		if ( $source_transport->is_file( $source ) ) {
-			$copy_results = $this->copy( $source, $destination, $overwrite );
-			if ( false === $copy_results ) {
-				return false;
-			}
-
-			// We don't need to set the errors here since delete() will take care of it
-			return $this->delete( $source );
+		$copy_results = $this->copy( $source, $destination, $overwrite );
+		if ( false === $copy_results ) {
+			return false;
 		}
 
-		return false;
+		// We don't need to set the errors here since delete() will take care of it
+		return $this->delete( $source );
 	}
 
 	/**