Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Allow sync manager queue to account for multisite context #5969

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Nov 2, 2024

Description

Currently, multisite context switching in the sync manager queue is not supported right now. This adds it per Automattic/ElasticPress#204. Should have no real material effect since get_sync_queue() replaces $this->sync_queue and has the same return.

Changelog Description

Fixed

  • Enterprise Search: Allow syncmanager to support multisite context for queues

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Copy link

sonarqubecloud bot commented Nov 2, 2024

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.43%. Comparing base (188bfd0) to head (f39df35).
Report is 26 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5969      +/-   ##
=============================================
+ Coverage      30.41%   30.43%   +0.01%     
  Complexity      4812     4812              
=============================================
  Files            288      288              
  Lines          21132    21120      -12     
=============================================
  Hits            6427     6427              
+ Misses         14705    14693      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rebeccahum rebeccahum marked this pull request as ready for review November 2, 2024 02:54
@rebeccahum rebeccahum requested a review from a team as a code owner November 2, 2024 02:54
@rebeccahum rebeccahum changed the title Search: Allow multisite context switching Search: Allow sync manager queue to account for multisite context Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants