Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDS: For search, track EP_IS_NETWORK constant #6050

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

rebeccahum
Copy link
Contributor

Description

For multisites, track in SDS whether EP_IS_NETWORK constant is set.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review December 12, 2024 23:57
@rebeccahum rebeccahum requested a review from a team as a code owner December 12, 2024 23:57
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.55%. Comparing base (3b7ecd5) to head (6c7f342).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
config/class-site-details-index.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6050      +/-   ##
=============================================
+ Coverage      30.53%   30.55%   +0.01%     
- Complexity      4811     4812       +1     
=============================================
  Files            289      289              
  Lines          21199    21189      -10     
=============================================
+ Hits            6474     6475       +1     
+ Misses         14725    14714      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rebeccahum rebeccahum force-pushed the sds/add-ep_is_network-constant-detection branch 2 times, most recently from cb8c5fa to e163917 Compare December 13, 2024 00:05
@rebeccahum rebeccahum force-pushed the sds/add-ep_is_network-constant-detection branch from e163917 to 6c7f342 Compare December 13, 2024 00:05
@rebeccahum rebeccahum merged commit a00e2b2 into develop Dec 13, 2024
36 checks passed
@rebeccahum rebeccahum deleted the sds/add-ep_is_network-constant-detection branch December 13, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants