Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack connection: How to handle disconnecting from Jetpack? #247

Closed
DanReyLop opened this issue Oct 25, 2019 · 2 comments
Closed

Jetpack connection: How to handle disconnecting from Jetpack? #247

DanReyLop opened this issue Oct 25, 2019 · 2 comments

Comments

@DanReyLop
Copy link
Contributor

Adding this for visibility and discussion in the open. The Jetpack Connection Task Force kickoff meeting has prompted some discussion about this: p1572023063121300-slack-wcpay

In a future where WCPay is connected to wp.com using the Jetpack connection package, how do we handle the merchant disconnecting said connection?

  • If WCPay is uninstalled or deactivated, that shouldn't affect the Jetpack connection or other Jetpack-connection-powered plugins, I think we can all agree on that.
  • If both WCPay and Jetpack are installed, and the merchant explicitly disconnects Jetpack, should the WCPay connection also be severed?
    • If yes, we should add a filter to this modal so we can present the merchant with more reasons why he shouldn't disconnect.
    • If no, then that means that disconnecting Jetpack won't affect the rest of the Jetpack-connection-based plugins. So, the site will only be truly disconnected from Jetpack when the last Jetpack-connection-powered plugin is uninstalled/deactivated?
@DanReyLop DanReyLop added this to the V0.7 - Settings, On-Boarding / Account Creation milestone Oct 25, 2019
@DanReyLop
Copy link
Contributor Author

Moved the discussion to the Jetpack repo: Automattic/jetpack#13843

@dwainm
Copy link
Contributor

dwainm commented Oct 30, 2019

Jetpack disconnect breaks the entire site, opened an issue here:
#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants