Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack disconnect breaks the site #249

Closed
dwainm opened this issue Oct 30, 2019 · 5 comments
Closed

Jetpack disconnect breaks the site #249

dwainm opened this issue Oct 30, 2019 · 5 comments
Labels
needs design The issue requires design input/work from a designer. status: has pr The issue has a PR. type: bug The issue is a confirmed bug.

Comments

@dwainm
Copy link
Contributor

dwainm commented Oct 30, 2019

When you disconnect Jetpack WCPay breaks and the whole site stops working.

To reproduce:

  1. Go to Admin > Jetpack > Dashboard > Connections section on the dashboard screen > Manage Site Connection.
  2. Click on disconnect.
@thenbrent
Copy link

thenbrent commented Oct 31, 2019

Related discussion on Automattic/jetpack#13843 with the likely fix mentioned here: Automattic/jetpack#13843 (comment)

@dwainm
Copy link
Contributor Author

dwainm commented Oct 31, 2019

It is related but not exactly the same thing. This plugin expects JP to be active and connected but does not fail gracefully a user clicks on disconnect after a connection has been established.

@reykjalin
Copy link
Contributor

I'm pretty sure this is one of the culprits:

// TODO: Either revamp this auth before releasing WCPay, or properly check that Jetpack is installed & connected.
if ( class_exists( 'Automattic\Jetpack\Connection\Client' ) ) {
return Automattic\Jetpack\Connection\Client::remote_request( $args, $body );
} else {
return Jetpack_Client::remote_request( $args, $body );
}

@dwainm dwainm added the needs design The issue requires design input/work from a designer. label Oct 31, 2019
@dwainm
Copy link
Contributor Author

dwainm commented Oct 31, 2019

As part of this, we should probably not load anything besides a hint to connect JP.

@dwainm
Copy link
Contributor Author

dwainm commented Sep 16, 2020

Fixed in #391

@dwainm dwainm closed this as completed Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design The issue requires design input/work from a designer. status: has pr The issue has a PR. type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants