Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge icon to the Uncaptured tab in Transactions page #5180

Closed
mgascam opened this issue Nov 24, 2022 · 7 comments
Closed

Add badge icon to the Uncaptured tab in Transactions page #5180

mgascam opened this issue Nov 24, 2022 · 7 comments
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: authorizations Improvements to the capture payment workflow priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.

Comments

@mgascam
Copy link
Contributor

mgascam commented Nov 24, 2022

Description

The number of transactions in the Uncaptured tab should be displayed inside a badge icon

Acceptance criteria

  • The number of transactions in the Uncaptured tab should be displayed inside a badge icon, not between parenthesis

Designs

Screenshot 2022-11-24 at 19 42 33

Dev notes

The TabPanel component that we used to implement the first iteration does not support passing an icon, only text. We need to find a way to pass the icon using the same component, or use a different component. Check additional context section.

Additional context

P2:
paJDYF-4N1-p2#comment-14875
paJDYF-4N1-p2#comment-14930

@mgascam mgascam added category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: authorizations Improvements to the capture payment workflow needs design The issue requires design input/work from a designer. and removed needs design The issue requires design input/work from a designer. labels Nov 24, 2022
@kalessil kalessil added type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project. and removed type: enhancement The issue is a request for an enhancement. labels Feb 5, 2024
@kalessil
Copy link
Contributor

kalessil commented Feb 5, 2024

Update: The components should be evaluated to see if the recommended one is production-ready.

@kalessil kalessil added the priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. label Feb 5, 2024
@kalessil kalessil added type: enhancement The issue is a request for an enhancement. and removed type: technical debt This issue/PR represents/solves the technical debt of the project. labels Feb 5, 2024
@mgascam
Copy link
Contributor Author

mgascam commented Feb 6, 2024

Update: The components should be evaluated to see if the recommended one is production-ready.

I had a look at the Tabs component, which was the recommended component, mentioned in the linked discussions: pbIJXs-2db-p2. Unfortunately, the component is labeled as experimental at this moment. It was first released as part of wordpress/components v25.9.0. For reference, the latest WordPress v6.4.3 uses wordpress/components v25.8.14.

In my opinion, it's too early to start using this component and we should wait until a more stable version is consolidated.
cc: @kalessil

@mgascam
Copy link
Contributor Author

mgascam commented Feb 7, 2024

After discussing with the team we decided to close the issue since the suggested wordpress/component is not ready for production use and this does not seem to be a high priority issue.

FYI: @bradyv since you were involved in the original discussion.

@mgascam mgascam closed this as completed Feb 7, 2024
@mgascam mgascam reopened this Feb 7, 2024
@mgascam mgascam closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
@kalessil
Copy link
Contributor

kalessil commented Feb 8, 2024

@elizaan36, @vbelolapotkov: you are likely the right people to ask.

In the context of updating UI/UX components, we have two factors: updating dependencies and experimental components.

Who are the right people to own and move forward with the related initiatives (example issues)?:

It feels like a waste of a good initiative, and if you have pointers to an umbrella ticket we'll link the closed ones.

@elizaan36
Copy link

hey @kalessil thanks for reaching out about these issues. We do need to focus on making these UI improvements holistically on Payments tables, and there's an initiative to redesign the UI to be more in line with the future state of the WordPress admin. @rogermattic has been taking a close look at this in relation to reporting and we should have more to share soon!

@rogermattic
Copy link

@kalessil just the heads up that those three issues are on my radar now and I will report back when I have some more context to share!

@kalessil
Copy link
Contributor

Sounds good @rogermattic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: authorizations Improvements to the capture payment workflow priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants