-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display an admin notice if neither Jetpack transport is available for WCPay #394
Conversation
includes/class-wc-payments.php
Outdated
|
||
$message = sprintf( | ||
/* translators: %1: WooCommerce Payments version */ | ||
__( 'WooCommerce Payments %1$s requires Jetpack at this time. Please install, activate and connect Jetpack.', 'woocommerce-payments' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think "at this time" is necessary, since it's referring to a specific version. (Though if we want to avoid implying that this is a permanent dependency, we could clarify that in a separate clause.)
Also, "some people" might be thrown off by the lack of comma after "activate" 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we did oxford commas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved language in f6c5255 but didn't add a comma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so TIL Oxford Commas means everyone gets a comma, and that it is a company style standard, so I relented and added a comma in a86c100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left one more comment but its not a blocker. (And neither is the comma…)
Replaced check_for_jetpack_layer introduced in #394.
Fixes #332
Related to #339 cc @vbelolapotkov
Changes proposed in this Pull Request
Testing instructions