Display an admin notice if neither Jetpack transport is available for WCPay #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dechov
reviewed
Feb 3, 2020
includes/class-wc-payments.php
Outdated
|
|
||
| $message = sprintf( | ||
| /* translators: %1: WooCommerce Payments version */ | ||
| __( 'WooCommerce Payments %1$s requires Jetpack at this time. Please install, activate and connect Jetpack.', 'woocommerce-payments' ), |
There was a problem hiding this comment.
I don't think "at this time" is necessary, since it's referring to a specific version. (Though if we want to avoid implying that this is a permanent dependency, we could clarify that in a separate clause.)
Also, "some people" might be thrown off by the lack of comma after "activate" 😄
There was a problem hiding this comment.
I thought we did oxford commas?
There was a problem hiding this comment.
Improved language in f6c5255 but didn't add a comma
There was a problem hiding this comment.
OK, so TIL Oxford Commas means everyone gets a comma, and that it is a company style standard, so I relented and added a comma in a86c100
dechov
approved these changes
Feb 4, 2020
1 task
vbelolapotkov
added a commit
that referenced
this pull request
Feb 5, 2020
Replaced check_for_jetpack_layer introduced in #394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
Related to #339 cc @vbelolapotkov
Changes proposed in this Pull Request
Testing instructions