Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra fields #762

Merged
merged 42 commits into from
Jul 15, 2024
Merged

Add extra fields #762

merged 42 commits into from
Jul 15, 2024

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented May 17, 2024

Make extra fields editable

Fix #810

Screenshot 2024-07-15 at 11 37 18 Screenshot 2024-07-15 at 11 37 33

@pfefferle pfefferle marked this pull request as ready for review May 20, 2024 18:50
@pfefferle pfefferle requested a review from mattwiebe May 20, 2024 18:50
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having these available will be nice! Left a few comments to clarify.

And it would be good to have these available for the Blog User as well!

includes/class-activitypub.php Show resolved Hide resolved
includes/class-activitypub.php Outdated Show resolved Hide resolved
includes/model/class-user.php Outdated Show resolved Hide resolved
mattwiebe
mattwiebe previously approved these changes May 30, 2024
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots in the PR description would be nice!

As we discussed, it'd be nice to have some form of migration and do display the defaults here:
Screenshot 2024-06-04 at 10 20 39

To me it was surprising to arrive in the Gutenberg editor when I clicked "Add new", it felt like a bug. What about just adding another row for quickly adding a new entry and the Edit link gives you full-text editing?

Mockup:
Screenshot 2024-06-04 at 10 23 40

<p>
<input class="regular-text" type="text" size="5" value="" placeholder="Field">
<input class="regular-text" type="text" value="" placeholder="Value">
</p>

@pfefferle pfefferle requested review from akirk and mattwiebe July 8, 2024 16:54
@github-actions github-actions bot added the Docs label Jul 15, 2024
@pfefferle
Copy link
Member Author

Should now also support FEP-fb2a:

"attachment": [
  {
    "type": "PropertyValue",
    "name": "Pronouns",
    "value": "<p>he/him/his</p>"
  },
  {
    "type": "Note",
    "name": "Pronouns",
    "content": "<p>he/him/his</p>"
  },
  {
    "type": "PropertyValue",
    "name": "Blog",
    "value": "<p><a rel=\"me noopener\" title=\"http://localhost:8076/\" target=\"_blank\" href=\"http://localhost:8076/\">localhost</a></p>"
  },
  {
    "type": "Link",
    "name": "Blog",
    "href": "http://localhost:8076/",
    "rel": [
      "me",
      "noopener"
    ]
  }
]

/cc @johnspurlock

@pfefferle pfefferle merged commit d226063 into master Jul 15, 2024
23 checks passed
@pfefferle pfefferle deleted the update/PropertyValue branch July 15, 2024 16:03
@jeherve
Copy link
Member

jeherve commented Aug 12, 2024

To me it was surprising to arrive in the Gutenberg editor when I clicked "Add new", it felt like a bug.

Coming in late to this discussion, to say that I experienced the same thing. To be honest, I'm still not sure I added the new field correctly. I created a new entry, with a title and just the link in the post content, but that didn't seem to work. I had to go back and add text with a link on it for it to appear in the profile page.

I like the idea of making this editable directly through the Profile page.

@pfefferle
Copy link
Member Author

Coming in late to this discussion, to say that I experienced the same thing. To be honest, I'm still not sure I added the new field correctly. I created a new entry, with a title and just the link in the post content, but that didn't seem to work. I had to go back and add text with a link on it for it to appear in the profile page.

This might be a bug, I will check this.

I like the idea of making this editable directly through the Profile page.

We can add that feature, but I still like having the Block editor to help with text and HTML. The extra fields are not limited to URLs, so why not profit from the build in features of WordPress?

@jeherve
Copy link
Member

jeherve commented Aug 13, 2024

The extra fields are not limited to URLs, so why not profit from the build in features of WordPress?

This is true. Maybe we could display a small rich text editable input field on the profile page?

@pfefferle
Copy link
Member Author

@jeherve Auto-Link comes with #849 btw.

@jeherve
Copy link
Member

jeherve commented Aug 14, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actor attachment objects are currently invalid per the spec
4 participants