Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS: Enable NoReservedKeywordParameterNames sniff #909

Merged
merged 5 commits into from
Oct 3, 2024
Merged

PHPCS: Enable NoReservedKeywordParameterNames sniff #909

merged 5 commits into from
Oct 3, 2024

Conversation

obenland
Copy link
Member

Proposed changes:

  • Replaced parameter names of reserved keywords with names that are not reserved.
  • Removed sniff exception.

See #905.

@obenland obenland self-assigned this Sep 28, 2024
@obenland obenland force-pushed the fix/NoReservedKeywordParameterNames-sniff branch from 1f0b226 to ea96f29 Compare September 29, 2024 22:56
pfefferle
pfefferle previously approved these changes Sep 30, 2024
View reviewed changes
@obenland obenland merged commit a2e7729 into trunk Oct 3, 2024
21 checks passed
@obenland obenland deleted the fix/NoReservedKeywordParameterNames-sniff branch October 3, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

@mattwiebe mattwiebe Awaiting requested review from mattwiebe

Assignees

@obenland obenland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenland @pfefferle