Fix link regex #922
Merged
Fix link regex #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwiebe
commented
Oct 2, 2024
pfefferle
requested changes
Oct 3, 2024
There was a problem hiding this comment.
@mattwiebe can you add the false positives to the test case?
Will do! Having a little trouble with the tests (again) but I'll circle back with fresh energy tomorrow |
pfefferle
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting a bunch of errors like this on wpcom:
This is because the previous regex was matching a string like
www foowhen it shouldn't be. I don't understand why the previous negated character class didn't work, but using the\Sclass is equivalent to^\s. I simplified thehttps?match a bit while I was in there.Proposed changes:
ACTIVITYPUB_URL_REGEXPOther information:
Testing instructions: